Fix defaultUrl sending hash content #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisrudge
force-pushed
the
fix-default-redirect-url-without-hash
branch
from
389d0d3
to
c4e1a55
Compare
lbalmaceda
reviewed
Oct 9, 2017
| @@ -266,7 +266,7 @@ function extractAuthOptions(options) { | |||
| // if responseType was not set and there is a redirectUrl, it defaults to code. Otherwise token. | |||
| responseType = typeof responseType === 'string' ? responseType : redirectUrl ? 'code' : 'token'; | |||
| // now we set the default because we already did the validation | |||
| redirectUrl = redirectUrl || window.location.href; | |||
| redirectUrl = redirectUrl || `${window.location.origin}${window.location.pathname}`; | |||
There was a problem hiding this comment.
Will this work on all browsers? Maybe it's better to have a function that splits the string in # and keeps the first left part.
There was a problem hiding this comment.
what part? strings interpolation or using location.origin and pathname?
luisrudge
force-pushed
the
fix-default-redirect-url-without-hash
branch
from
c4e1a55
to
aaa56b3
Compare
lbalmaceda
approved these changes
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.