Fixed login_hint in some enterprise authorize call scenarios #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisrudge
reviewed
Aug 6, 2018
src/core/web_api/p2_api.js
Outdated
| @@ -58,14 +58,29 @@ class Auth0APIClient { | |||
| } | |||
|
|
|||
| logIn(options, authParams, cb) { | |||
| debugger; | |||
luisrudge
reviewed
Aug 6, 2018
| }); | ||
|
|
||
| if (options.login_hint) { | ||
| loginOptions.login_hint = options.login_hint; |
There was a problem hiding this comment.
please add a test for this. file: https://github.com/auth0/lock/blob/master/src/__tests__/core/web_api/p2_api.test.js#L105
cocojoe
force-pushed
the
fixed-login-hint-enterprise
branch
from
f6d9e8f
to
8da77e5
Compare
|
Formatting changes are from the lint that runs as part of the commit process. |
luisrudge
reviewed
Aug 6, 2018
| @@ -1,4 +1,5 @@ | |||
| import { setURL } from 'testUtils'; | |||
| import { equal } from 'assert'; | |||
luisrudge
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the supplied login_hint is used over any default auth/params
Fixes: #1426