-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return results with signup success callback #1799
Conversation
@bstaley thanks for the contribution. Please, update the PR title and description trying to follow the template. Someone will pick it up then. |
@bstaley Has the new work here been submitted on top of another PR? The commits here don't seem to reflect the actual changes in the changeset. As @lbalmaceda, the lack of a title and appropriate description make it hard to understand the context of the PR. Feel free to submit a fresh PR if that makes it easier to propose the change. |
Yes, because my fork was behind and you guys already did most of the work the following would be the only real change
I will go and modify the title and description. |
@bstaley Thanks! |
* updated lock to have signup success * updated version * updated package name * updated entity reference * small readme fix
* updated lock to have signup success * updated version * updated package name * updated entity reference * small readme fix
* updated lock to have signup success * updated version * updated package name * updated entity reference * small readme fix
Changes
Added the results to the
signup success
callback. This is needed for persisting this data in client databases.References
#1748
Testing
To test please use
lock.on('signup success', (results) => { console.log(results); })
Checklist