Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

z-index needs to be less than the close button to avoid hiding it #1872

Merged
merged 2 commits into from
Jun 1, 2020
Merged

z-index needs to be less than the close button to avoid hiding it #1872

merged 2 commits into from
Jun 1, 2020

Conversation

adamjmcgrath
Copy link
Contributor

@adamjmcgrath adamjmcgrath commented May 22, 2020 •
edited
Loading

Changes

The header is further down in the DOM than the close button and they have matching z-index values so the header is overlaying the close button

https://github.com/auth0/lock/blob/master/css/index.styl#L178
https://github.com/auth0/lock/blob/master/css/index.styl#L204

close button z-index should be > header z-index

References

fixes #1863

Testing

image

Also tested in IE11

Checklist

@adamjmcgrath adamjmcgrath requested a review from a team May 22, 2020 10:37
@adamjmcgrath adamjmcgrath merged commit 1dd2fba into master Jun 1, 2020
@adamjmcgrath adamjmcgrath deleted the fix-close-button branch June 1, 2020 17:26
@stevehobbsdev stevehobbsdev added this to the vNext milestone Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v11.24.2
Development

Successfully merging this pull request may close these issues.

close button is missing
2 participants
@adamjmcgrath @stevehobbsdev