Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better flash error messages on incorrect, empty fields. #1923

Merged
merged 4 commits into from
Sep 15, 2020
Merged

Better flash error messages on incorrect, empty fields. #1923

merged 4 commits into from
Sep 15, 2020

Conversation

saltukalakus
Copy link
Contributor

Changes

1- Password field in signup view was showing the invalid flash password error when the field was blank. This commit fixes this by showing the password field as blank in that condition.

2- Our blank and invalid messages are same for all the fields. By adding new translations it is now possible to configure different messages. This is implemented in a backwards compatible way.

Screen Shot 2020-09-11 at 01 55 14

References

This was raised in a support ticket.

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@saltukalakus saltukalakus requested a review from a team September 10, 2020 23:35
@saltukalakus saltukalakus changed the title Better flash error messages on incorrect, empty fields. WIP - Better flash error messages on incorrect, empty fields. Sep 11, 2020
@stevehobbsdev
Copy link
Contributor

@saltukalakus If this is a WIP, could you please convert the PR into a draft until it is time to review. Thanks.

@saltukalakus saltukalakus marked this pull request as draft September 14, 2020 21:07
@saltukalakus saltukalakus changed the title WIP - Better flash error messages on incorrect, empty fields. Better flash error messages on incorrect, empty fields. Sep 14, 2020
@saltukalakus saltukalakus marked this pull request as ready for review September 14, 2020 21:34
@saltukalakus
Copy link
Contributor Author

👋 @stevehobbsdev this one is ready for review.

With yarn dev you may not run it correctly, as the language file comes from the CDN. I have tested the changes with yarn build and inserting lock and language files in the universal login HTML for that reason.

Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stevehobbsdev stevehobbsdev merged commit dbf0e2f into auth0:master Sep 15, 2020
@stevehobbsdev stevehobbsdev added this to the v11.27.0 milestone Sep 18, 2020
@stevehobbsdev stevehobbsdev mentioned this pull request Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants