[ESD-10373] Fix rendering of Lock inside popup on first open #1948
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1942, where the Lock sometimes does not render properly when first
opened on Safari. It was found that the logo image sometimes causes this
behaviour and removing it from the UI causes the issue to go away completely.
The fix in this PR is to cause Safari to redraw by specifying
a non-consequential font size change when the logo image is loaded. In my
testing, this appears to fix the issue.
Prior to the fix, this can be reproduced fairly reliably (50% of the time by my
reckoning) by:
References
#1942
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist