Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESD-10373] Fix rendering of Lock inside popup on first open #1948

Merged
merged 6 commits into from
Dec 16, 2020

Conversation

stevehobbsdev
Copy link
Contributor

Changes

Fixes #1942, where the Lock sometimes does not render properly when first
opened on Safari. It was found that the logo image sometimes causes this
behaviour and removing it from the UI causes the issue to go away completely.

The fix in this PR is to cause Safari to redraw by specifying
a non-consequential font size change when the logo image is loaded. In my
testing, this appears to fix the issue.

Prior to the fix, this can be reproduced fairly reliably (50% of the time by my
reckoning) by:

  • Open the Lock UI in a popup in Safari
  • Open developer tools and ensure network caching is off
  • Continually refresh the popup content using Cmd+R
  • Observe that sometimes the Lock will render properly, sometimes not

References

#1942

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@stevehobbsdev stevehobbsdev requested a review from a team as a code owner December 14, 2020 12:48
@stevehobbsdev stevehobbsdev added CH: Fixed bug This points to a verified bug in the code review:tiny Tiny review labels Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This points to a verified bug in the code review:tiny Tiny review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safari intermittently fails to display passwordless login form
2 participants