Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2823] Fix password reset when using custom connection resolver #2048

Merged
merged 3 commits into from
Oct 6, 2021

Conversation

stevehobbsdev
Copy link
Contributor

Changes

This PR addresses an issue where, if using the password reset feature and also using a custom connection resolver, the email address is not auto-populated. This does happen if not using a custom resolver, so this PR aligns those scenarios.

It does this by copying the value from the username field into email, if the value validates as an email address (using non-strict validation).

Notes

  • When using a custom resolver, usernameStyle is always username
  • Password Reset always requires an email address. If the value doesn't validate as an email address (because you can enter either on the login screen) then the value is blanked out on the password reset screen.

References

Fixes #2038

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

Steve Hobbs added 3 commits October 4, 2021 13:12
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevehobbsdev The changes in reset_password and its tests LGTM. I wonder if the rest of the diff was included by mistake, as those are mostly build files being removed --> +162 −48,564

Note that browserstack tests are failing

@stevehobbsdev
Copy link
Contributor Author

I wonder if the rest of the diff was included by mistake

No, there is an explicit commit that removes them. I've discovered the downside of forcing ignored files into Git is that on the next commit they will be removed again, since Git will see them as deleted files. I think the least obtrusive way forward is to just include the build files in the repo and remove the entry from .gitignore.

Note that browserstack tests are failing

Yep, they will continue to intermittently fail until I invest some time in fixing them, which I am planning to do shortly.

@stevehobbsdev stevehobbsdev requested a review from a team October 6, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Forgot password" e-mail input gets wiped out when a connectionResolver is configured
2 participants