[ESD-16401] Ensure Captcha is completed before authenticating with enterprise connection #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
commented
Oct 27, 2021
| @@ -0,0 +1,72 @@ | |||
| import * as l from '../core/index'; | |||
There was a problem hiding this comment.
This is all pre-existing logic, and has just been extracted into a new module so that it can be shared between database and enterprise connection logic in the source tree.
stevehobbsdev
commented
Oct 27, 2021
| @@ -33,7 +33,7 @@ function shouldRenderTabs(m) { | |||
| return hasScreen(m, 'signUp'); | |||
| } | |||
|
|
|||
| const Component = ({ i18n, model }) => { | |||
| const LoginComponent = ({ i18n, model }) => { | |||
There was a problem hiding this comment.
I renamed this so that the component name makes more sense when debugging with React developer tools.
lbalmaceda
approved these changes
Oct 28, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes an issue where the user can skip completing the captcha when using an enterprise connection, and makes sure the captcha is valid before proceeding with login.
Notes
Since some of the logic I needed to implement this existed under the database implementation, I extracted the bits out to a new file
captcha.jsto share the logic between database and enterprise.Video
Video shows a working implementation:
Screen.Recording.2021-10-27.at.11.41.30.mov
References
ESD-16401(internal ticket)Testing
BrowserStack tests are still a bit flakey but I've verified that the E2E tests pass locally.
Checklist