Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registry-url to setup-node step in npm publish #2445

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

ewanharris
Copy link
Contributor

Changes

Adds the npmjs registry url to setup-node as mentioned in the GitHub docs for publishing npm packages

References

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@ewanharris ewanharris requested a review from a team as a code owner September 18, 2023 08:53
@ewanharris ewanharris temporarily deployed to internal September 18, 2023 08:53 — with GitHub Actions Inactive
@ewanharris ewanharris temporarily deployed to internal September 18, 2023 08:53 — with GitHub Actions Inactive
@ewanharris ewanharris temporarily deployed to internal September 18, 2023 08:53 — with GitHub Actions Inactive
@ewanharris ewanharris temporarily deployed to internal September 18, 2023 08:56 — with GitHub Actions Inactive
@ewanharris ewanharris temporarily deployed to internal September 18, 2023 09:00 — with GitHub Actions Inactive
@ewanharris ewanharris added this pull request to the merge queue Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bf250d7) 41.71% compared to head (e54549b) 41.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2445   +/-   ##
=======================================
  Coverage   41.71%   41.71%           
=======================================
  Files         120      120           
  Lines        3028     3028           
  Branches      327      327           
=======================================
  Hits         1263     1263           
  Misses       1673     1673           
  Partials       92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants