Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registry-url to setup-node #2458

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Add registry-url to setup-node #2458

merged 1 commit into from
Oct 6, 2023

Conversation

ewanharris
Copy link
Contributor

Changes

Adds registry-url to the setup-node step to ensure publishing will work in future

References

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@ewanharris ewanharris requested a review from a team as a code owner October 5, 2023 15:30
@ewanharris ewanharris temporarily deployed to internal October 5, 2023 15:30 — with GitHub Actions Inactive
@ewanharris ewanharris temporarily deployed to internal October 5, 2023 15:30 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (00a27d5) 41.71% compared to head (8c1377f) 41.71%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2458   +/-   ##
=======================================
  Coverage   41.71%   41.71%           
=======================================
  Files         120      120           
  Lines        3028     3028           
  Branches      327      327           
=======================================
  Hits         1263     1263           
  Misses       1673     1673           
  Partials       92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frederikprijck frederikprijck merged commit 199d92c into master Oct 6, 2023
11 checks passed
@frederikprijck frederikprijck deleted the ewanharris-patch-1 branch October 6, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants