Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to npm and use automated release process #2508

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Dec 15, 2023

Changes

To ease automated release, migrated lock to use npm instead of yarn and implemented our automated release process.
This is also more consistent with our other JS SDKs.

I compared the distributed lock.js file before and after this change, and they are identical.

Checklist

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea1c9fc) 42.19% compared to head (8d581c8) 42.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2508   +/-   ##
=======================================
  Coverage   42.19%   42.19%           
=======================================
  Files         120      120           
  Lines        3076     3076           
  Branches      334      334           
=======================================
  Hits         1298     1298           
  Misses       1684     1684           
  Partials       94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frederikprijck frederikprijck marked this pull request as draft December 15, 2023 10:08
@frederikprijck
Copy link
Member Author

frederikprijck commented Dec 15, 2023

Putting in draft, and see if it makes sense to make the release process work with yarn as well, as our react-native repository also uses yarn and we probably can not migrate all.

@frederikprijck frederikprijck marked this pull request as ready for review December 15, 2023 11:18
@frederikprijck
Copy link
Member Author

Let's migrate to npm. We will also migrate RNA to npm.

@frederikprijck frederikprijck merged commit ed58823 into master Dec 15, 2023
11 checks passed
@frederikprijck frederikprijck deleted the feat/automated-release-process branch December 15, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants