Fix EscKeyDownHandler bug in Container when closable
is false
#604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There is a bug in lock when Container is set to
container: "name"
and theESC
button is pressed, this error occurs:The lock has the
container
UI option set totrue
, which should causeclosable
to change tofalse
as well, as per the #Customization section in the docs - so this behavior should not be expected, since the lock is still expecting a function to handle close.Changes Proposed:
EscKeyDownHandler
tothis.escKeydown
when acloseHandler
prop exists.this.escKeydown
ifthis.escKeydown
exists on Container unmount.The changes above should prevent any further errors from the container attempting to close, when it should not be able to.