Added checkbox CustomInput for additionalSignUpFields #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed broken test
selaux
reviewed
Feb 8, 2017
| additionalSignUpFields: [{ | ||
| type: "checkbox", | ||
| name: "newsletter", | ||
| prefill: "true", |
There was a problem hiding this comment.
Is there any reason for this being a string instead of a boolean value?
There was a problem hiding this comment.
I wanted to keep the modifications as small as possible.
The prefill value is needed otherwise the checkbox will be "invalid" in the store and the registration won't go through.
Prefill must be string: https://github.com/auth0/lock/blob/master/src/connection/database/index.js#L107
I could change that, but it would need a lot of other changes elsewhere in the code
hzalaz
approved these changes
Feb 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently additionalSignUpFields parameter lets you use only the type "input" and "select".
In this PR I introduce the CheckBox custom input, which is often very useful in the registration process to accept subscription to the newsletter.
I kept the UI and font similar to the acceptTerms checkbox, but removed the gray background, see here:
