Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update password sheriff to reduce bundle size #879

Merged
merged 1 commit into from
Feb 24, 2017

Conversation

hzalaz
Copy link
Member

@hzalaz hzalaz commented Feb 23, 2017

No description provided.

@hzalaz hzalaz added this to the v10-Next milestone Feb 23, 2017
luisrudge
luisrudge previously approved these changes Feb 24, 2017
Copy link
Contributor

@luisrudge luisrudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@luisrudge
Copy link
Contributor

luisrudge commented Feb 24, 2017

@hzalaz I found a bug. not sure it's related to password-sherif:
upper case letters is being marked with a green check, but the text isn't green (I didn't type an upper case letter).

image

(I changed to <input type="text> to show the text)

@luisrudge
Copy link
Contributor

luisrudge commented Feb 24, 2017

The error above also happens with master, so I'll approve this and create another issue: #881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants