Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not show popup if sso false #915

Closed
wants to merge 1 commit into from

Conversation

maxbeatty
Copy link

Trying to fix #912

From the popup docs, my understanding is that setting sso: false should prevent a popup. Right now, the popup is dictated by redirect: false.

Ultimately, I'd like to sign up a user without redirecting and without a popup.

@hzalaz
Copy link
Member

hzalaz commented Mar 10, 2017

Thanks for the PR but but this will break our API since what tells lock if its popup or not is redirect option so we won't merge this.

The fix to the underlying issue will be done in auth0.js soon

@hzalaz hzalaz closed this Mar 10, 2017
@maxbeatty
Copy link
Author

Can you point me to the fix being made in auth0.js?

I'm a paying customer who can't sign up new users. I'd like to do whatever I can to resolve this as quick as possible.

@hzalaz
Copy link
Member

hzalaz commented Mar 10, 2017

@maxbeatty I can't since as I said before will be done so we haven't started on it but it should be available next week
You could probably downgrade Lock to 10.8.x as a quick workaround until we release a new lock version since the toSnakeCase is part of our update of auth0.js and was added in 10.9.x.

Also as a paying customer I'd strongly recommend using https://support.auth0.com since we don't check 24/7 github issues and we can't ensure an SLA, provide quick support or even tell paying customers from non-paying ones.

@maxbeatty
Copy link
Author

I submitted a support ticket shortly after opening the PR. You've been faster to respond here on GitHub and it's much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack overflow error in lock.js when signing up with user/password
2 participants