Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes to support mTLS authentication #1002

Merged
merged 7 commits into from
May 7, 2024
Merged

Conversation

gyaneshgouraw-okta
Copy link
Contributor

@gyaneshgouraw-okta gyaneshgouraw-okta commented Apr 28, 2024

Changes

Please describe both what is changing and why this is important. Include:

  • Added relevant changes to start supporting mTLS authentication
  • As part of the change a new boolean parameter useMTLS, if passed as true, it will append mtls prefix to required authentication endpoints.
  • If value useMTLS is true , validation for clientSecret & client assertion signing key will be skipped.

References

Please include relevant links supporting this change such as a:

  • mTLS auth0 documentation - Link

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • Verified different client authentication flows like passwordless, database & other oauth methods
  • mTLS configuration worked correctly, required access token were received on successful request
  • This change adds unit test coverage
  • This change adds integration test coverage

Checklist

@gyaneshgouraw-okta gyaneshgouraw-okta requested a review from a team as a code owner April 28, 2024 18:18
src/auth/base-auth-api.ts Outdated Show resolved Hide resolved
EXAMPLES.md Show resolved Hide resolved
src/auth/oauth.ts Outdated Show resolved Hide resolved
src/lib/runtime.ts Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants