replaced superagent with request #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehsis
force-pushed
the
master
branch
2 times, most recently
from
212cbb2
to
313fb18
Compare
tehsis
force-pushed
the
master
branch
2 times, most recently
from
e8f2c1d
to
f075dfb
Compare
|
Discussed not returning from reject/resolve but this was previous behavior, so not changing to keep consistency with prior behavior. |
|
LGTM |
dschenkelman
suggested changes
Sep 27, 2016
| @@ -56,6 +56,30 @@ utils.wrapPropertyMethod = function (Parent, name, propertyMethod) { | |||
| */ | |||
| utils.getRequestPromise = function (settings) { | |||
| return new Promise(function (resolve, reject) { | |||
| var json = null; | |||
There was a problem hiding this comment.
where are you using these?
| @@ -8,12 +8,12 @@ module.exports = function (body, boundary) { | |||
| .split(partRegexp) | |||
| .forEach(function (part) { | |||
| // Ignore empty strings in the array. | |||
| if (part.length === 0) return; | |||
| if (part.trim().length === 0) return; | |||
There was a problem hiding this comment.
is this request related? change in tests?
There was a problem hiding this comment.
yes, not really sure about this. But the headers on request has some whitespaces between that's why I needed to trim them.
This is using request:
----------------------------454702286045209682268136
Content-Disposition: form-data; name="users"; filename="users.json"
Content-Type: application/json
[]
----------------------------454702286045209682268136
Content-Disposition: form-data; name="connection_id"
con_test
----------------------------454702286045209682268136--
and this superagent:
----------------------------392237490125139977580197Content-Disposition: form-data; name="connection_id"con_test----------------------------392237490125139977580197Content-Disposition: form-data; name="users"; filename="users.json"Content-Type: application/json[]----------------------------392237490125139977580197--
Do you think it can be an issue?
| @@ -1,6 +1,7 @@ | |||
| var request = require('superagent'); | |||
| var request = require('request'); | |||
There was a problem hiding this comment.
why don't we use request-promise
There was a problem hiding this comment.
I just wanted to made as few changes as possible while providing consistency
dschenkelman
approved these changes
Sep 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
superagentwithrequestand adds some workarounds to not break current behavior.