JobsManager handling importUsers response payload #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpatrick
changed the title
lbalmaceda
suggested changes
May 27, 2020
Currently Tokens and User manager return response data, while Jobs is returning the request. To avoid a breaking change, and make the experience consistent with the Jobs manager, we are adding a new function `importUsersJob` that will extract the data from the response
davidpatrick
force-pushed
the
davidpatrick-patch-1
branch
from
87ce953
to
7df4ce8
Compare
lbalmaceda
approved these changes
May 28, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently TokensManager and UserManager return response data, while Jobs is returning the whole response. To avoid a breaking change, and make the experience consistent with the Jobs manager, we are adding a new function
importUsersJobthat will extract the data from the responseFollow up to #491
Closes #467