Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jwks-rsa dependency to avoid DeprecationWarning Buffer() #534

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Update jwks-rsa dependency to avoid DeprecationWarning Buffer() #534

merged 2 commits into from
Sep 22, 2020

Conversation

jalie
Copy link
Contributor

@jalie jalie commented Sep 16, 2020

Changes

  • updated jwks-rsa to latest version 1.9.0 to fix DeprecationWarning about Buffer()

References

The newest jwks-rsa version is using the recommended porting from Buffer:
auth0/node-jwks-rsa#154

About the Buffer porting in general:
https://nodejs.org/fr/docs/guides/buffer-constructor-deprecation/

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage

Checklist

@jalie jalie requested a review from a team September 16, 2020 12:00
@davidpatrick
Copy link
Contributor

Thanks for the PR @jalie

@davidpatrick davidpatrick merged commit e166dbd into auth0:master Sep 22, 2020
@davidpatrick davidpatrick added this to the v2.29.0 milestone Sep 23, 2020
@davidpatrick davidpatrick mentioned this pull request Sep 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpatrick davidpatrick davidpatrick approved these changes

Assignees
No one assigned
Labels
CH: Changed
Projects
None yet
Milestone
v2.29.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jalie @davidpatrick