Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop node-fetch and only use native fetch #908

Merged
merged 6 commits into from
Aug 16, 2023

Conversation

frederikprijck
Copy link
Member

Changes

Builds on top of #906 to drop node-fetch altogether given we will only support node18+, which supports native fetch.

Additionally, given nock does not support native fetch, we still use node-fetch when running our tests that rely on nock.

References

nock/nock#2397

Checklist

@frederikprijck frederikprijck requested a review from a team as a code owner August 15, 2023 20:10
src/lib/runtime.ts Outdated Show resolved Hide resolved
src/lib/runtime.ts Outdated Show resolved Hide resolved
src/lib/runtime.ts Outdated Show resolved Hide resolved
@frederikprijck frederikprijck merged commit 5c387f0 into native-fetch Aug 16, 2023
1 check passed
@frederikprijck frederikprijck deleted the native-fetch-drop-node-fetch branch August 16, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants