Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce import cost of lodash #889

Closed
wants to merge 1 commit into from
Closed

Reduce import cost of lodash #889

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 22, 2023 •
edited by ghost
Loading

Description

Use direct lodash imports to reduce downstream bundle sizes.

Checklist

  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@jimmywarting
Copy link

I think most of this can be inlined (coded by hand / plain vanilla javascript)

@ghost
Copy link
Author

ghost commented Mar 8, 2023 •
edited by ghost
Loading

@jimmywarting Yep, I agree.

But this approach was used to reduce any potential impact of this change for the maintainers.

Related: #887 #879

@ghost ghost closed this by deleting the head repository May 1, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmywarting @araphiel-chwy