Rewrite in Typescript #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update jest configs
|
@jharrilim amazing work! Do you still have something left to change/rewrite? I could help if so, because I'd also like to have the typings available. Cheers! |
|
Hi there! It has been a while since I touched this, but from what I remember the code should work exactly the same. After a quick glance right now though, I have noticed that a few things are missing from the package.json, which I think might be necessary: {
"publishConfig": {
"access": "public"
},
"files": [
"/lib"
]
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I am currently in the progress of rewriting this and node-jws in Typescript. I noticed a few lingering issues in node-jws so I figured I'd give it a rewrite. It relies on node-jwa which does not have types included. The aim of this rewrite is to hopefully increase the maintainability and hardiness.
For now the code is nearly one-to-one with the original with a few new runtime assertions. The tests are currently being rewritten to take advantage of jest. The RFC 7515 - Appendix A examples have been rewritten so far and currently pass. The other examples will be converted soon.
Edit: I have removed support for Node versions that are no longer supported in
travis.ymlas well as added thepackage-lock.jsonso that npm ci is usable.The keys for testing are now permanently added as test fixtures.
Automated documentation can now be done using Typedoc. This should work in tandem with Travis Github Pages deployments.