Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for hapi 17.x.x #38

Merged
merged 1 commit into from
May 23, 2018
Merged

Conversation

degrammer
Copy link
Contributor

Add support for hapi-auth-jwt2 8.x.x using Hapi 17.x.x as documented on
https://github.com/dwyl/hapi-auth-jwt2#compatibility

Introduced a new promised based method hapiJwt2KeyAsync

@diegobfernandez diegobfernandez mentioned this pull request Apr 5, 2018
@dynajoe
Copy link

dynajoe commented Apr 8, 2018

+1 for release

@dynajoe
Copy link

dynajoe commented Apr 8, 2018

Anything we can do to help?

@smessimer
Copy link

+1 It would be great to get this merged in soon.

@dynajoe
Copy link

dynajoe commented Apr 14, 2018

Until it’s merged it’s easy enough to just copy the function.

@MatthewCallis
Copy link

Anyway to get this merged in? cc: @sandrinodimattia

@robinvdvleuten
Copy link

What needs to be done to get this merged in?

@cocojoe cocojoe added this to the v1-Next milestone May 23, 2018
@cocojoe cocojoe self-requested a review May 23, 2018 10:48
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cocojoe cocojoe merged commit 195bac5 into auth0:master May 23, 2018
@adematte
Copy link
Contributor

Any ETA on the release for that fix ?

@cocojoe
Copy link
Member

cocojoe commented Jun 4, 2018

We wanted to also add #31 so giving the PR author a chance to complete. If not will release shortly for this.

@nalwayaabhishek
Copy link

Any ETA for this release?

@cocojoe
Copy link
Member

cocojoe commented Jul 24, 2018

It was in the 1.3.0 release? 49b5cd4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants