-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base64 encoded tokens (with padding) rejected #22
Comments
I created a PR for this: #25 |
omsmith
added a commit
to omsmith/node-jws
that referenced
this issue
Jul 19, 2015
omsmith
added a commit
to omsmith/node-jws
that referenced
this issue
Jul 19, 2015
omsmith
added a commit
to omsmith/node-jws
that referenced
this issue
Jul 19, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have tokens that appear to have been generated using base64 encoding instead of base64url encoding (3rd party auth system) and line 8 of verify-stream.js defines the pattern which the token must match. That doesn't currently include '=' padding, which is causing these tokens to be rejected as invalid.
I'm reading through the spec, and while it's pretty clear that token issuers should not include padding, it also appears to recommend that validation should allow for padding.
Thoughts?
The text was updated successfully, but these errors were encountered: