Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for per-participant bindings during SLO #135

Merged
merged 9 commits into from
Jul 24, 2023

Conversation

ArtiomCiumac
Copy link
Contributor

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Add support for participant-specific bindings for SLO. The library will use the correct binding if it is specified in the SessionParticipant structure.

Testing

  1. Set up SAML SLO with multiple participants.
  2. Add a binding field in the participant structure with mixed values.
  3. Trigger SAML SLO and observe that each participant gets called using its specific binding.

See the added tests for details.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

kbrimble
kbrimble previously approved these changes Jul 6, 2023
README.md Outdated Show resolved Hide resolved
lib/logout.js Outdated Show resolved Hide resolved
test/samlp.logout.session_store.tests.js Show resolved Hide resolved
CharlesRea
CharlesRea previously approved these changes Jul 10, 2023
@ArtiomCiumac ArtiomCiumac marked this pull request as ready for review July 20, 2023 09:58
UdoBretz
UdoBretz previously approved these changes Jul 20, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

@CharlesRea CharlesRea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a change needed on the changelog before approving

Updated to reflect correct changes since last release.

Co-authored-by: Charles Rea <charles@charlesrea.net>
CharlesRea
CharlesRea previously approved these changes Jul 20, 2023
@CharlesRea CharlesRea merged commit 46305eb into master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants