Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parses provider from user_id if identities is not provided. #103

Merged
merged 4 commits into from
Dec 6, 2019
Merged

Parses provider from user_id if identities is not provided. #103

merged 4 commits into from
Dec 6, 2019

Conversation

kertof
Copy link
Contributor

@kertof kertof commented Dec 4, 2019

Description

If the data from Auth0 does not contain identities, parse the 'provider' from the user_id, which has the provider in it.

This change also has formatting updates, removes whitespace.

References

Closes #102

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@kertof kertof requested a review from a team December 4, 2019 14:10
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kertof - Appreciate the contribution here! I have a few suggestions and would like to see this without any whitespace changes so the core functionality changes are clear.

Thank you!

lib/Profile.js Show resolved Hide resolved
lib/Profile.js Outdated Show resolved Hide resolved
Copy link
Contributor Author

@kertof kertof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted the whitespace changes. Let me know what you think.
For the fixtures, I reused the ones already there, the expected values are hard-coded in userprofile.tests.js.

lib/Profile.js Show resolved Hide resolved
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @kertof, appreciate the work here 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Fixed small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the userProfile does not have 'provider' field correctly populated.
2 participants