-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parses provider from user_id if identities is not provided. #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kertof - Appreciate the contribution here! I have a few suggestions and would like to see this without any whitespace changes so the core functionality changes are clear.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reverted the whitespace changes. Let me know what you think.
For the fixtures, I reused the ones already there, the expected values are hard-coded in userprofile.tests.js.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @kertof, appreciate the work here 🙇
Description
If the data from Auth0 does not contain identities, parse the 'provider' from the user_id, which has the provider in it.
This change also has formatting updates, removes whitespace.
References
Closes #102
Testing
Checklist
master