Fix missing ID causing cannot read error #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The id of the profile should be a string but if the openid scope is not used during login, a profile can be returned but not parsed by this strategy. Developers should use the openid scope but this strategy should enforce that at startup, not fail during callback.
joshcanhelp
commented
Dec 31, 2019
| @@ -1,11 +1,11 @@ | |||
| { | |||
There was a problem hiding this comment.
Changing to dummy data
joshcanhelp
commented
Dec 31, 2019
| @@ -1,20 +1,19 @@ | |||
| { | |||
There was a problem hiding this comment.
Changing to dummy data
joshcanhelp
commented
Dec 31, 2019
| @@ -1,20 +1,19 @@ | |||
| { | |||
There was a problem hiding this comment.
Changing to dummy data
lbalmaceda
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
idof the Passport profile should be a string but if theopenidscope is not used during login, a profile may still be returned. This PR fixes the error during callback caused by a missingsubanduser_idon the returned profile. Additionally, it checks for the split character to make sure thatprovideris not set to theid.Developers should use the
openidscope but this strategy should enforce that at startup, not fail during callback.References
Closes #105
Testing