AuthenticationController::$container must not be defined

[mkilmanas]

Checklist

• I have looked into the Readme and have not found a suitable solution or answer.
• I have searched the issues and have not found a suitable solution or answer.
• I have searched the Auth0 Community forums and have not found a suitable solution or answer.
• I agree to the terms within the Auth0 Code of Conduct.

Description

When updating to 5.2.2 composer throws this error during Symfony cache:clear step:

 [KO]
Script cache:clear returned with error code 255
!!
!!  Fatal error: Type of Auth0\Symfony\Controllers\AuthenticationController::$container must not be defined (as in class Symfony\Bundle\FrameworkBundle\Controller\AbstractController) in /xyz/vendor/auth0/symfony/src/Controllers/AuthenticationController.php on line 20
!!  PHP Fatal error:  Type of Auth0\Symfony\Controllers\AuthenticationController::$container must not be defined (as in class Symfony\Bundle\FrameworkBundle\Controller\AbstractController) in /xyz/vendor/auth0/symfony/src/Controllers/AuthenticationController.php on line 20
!!  Symfony\Component\ErrorHandler\Error\FatalError {#3008
!!    #message: "Compile Error: Type of Auth0\Symfony\Controllers\AuthenticationController::$container must not be defined (as in class Symfony\Bundle\FrameworkBundle\Controller\AbstractController)"
!!    #code: 0
!!    #file: "./vendor/auth0/symfony/src/Controllers/AuthenticationController.php"
!!    #line: 20
!!    -error: array:4 [
!!      "type" => 64
!!      "message" => "Type of Auth0\Symfony\Controllers\AuthenticationController::$container must not be defined (as in class Symfony\Bundle\FrameworkBundle\Controller\AbstractController)"
!!      "file" => "/xyz/vendor/auth0/symfony/src/Controllers/AuthenticationController.php"
!!      "line" => 20
!!    ]
!!  }
!!
Script @auto-scripts was called via post-update-cmd

I presume it refers to this declaration of the property here vs [the property already declared by the parent class without the type restriction].(https://github.com/symfony/symfony/blob/6.4/src/Symfony/Bundle/FrameworkBundle/Controller/AbstractController.php#L58-L61)
Type restriction was actually introduced in Symfony 7.0, so I suspect this was an attempt at upgrading/making-compatible.

I would suggest removing the protected keyword and using the setter method provided - that way it will be compatible both with 6.x and 7.x.

E.g.

    public function __construct(
        private Authenticator $authenticator,
        private RouterInterface $router,
       ContainerInterface $container,
    ) {
        $this->setContainer($container);
    }

Reproduction

1. Install this bundle into a symfony project
2. use composer update to upgrade this bundle to v5.2.2

Additional context

No response

jwt-auth-bundle version

5.2.2

Symfony version

6.4.1

PHP version

8.2

[evansims]

Resolved by #179