-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use Symfony PSR-6 > PSR-16 cache adapter #110
Conversation
Hey, @darthf1, thanks for this! 👋 I tried going this Psr16Adapter route during the previous commit but I kept encountering exceptions around Psr16Adapter being unable to accept instances of Symfony\Component\Cache\Adapter\TraceableAdapter, and I could never figure out a workaround for it. I'll give this a try next week and see if this works better! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! No idea why this was throwing an error for me before but all appears well now, so all the better! Thanks for your contribution!
Great! Do you want me to remove the helper and the related test as well as they're not used anymore? |
That would be great if you don't mind @darthf1 |
@evansims no problem, done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate it! Just need to fix an issue with our status checks on the repo before I can merge, hang tight.
Changes
With this change, Symfony's cache adapter is used instead of the one provided by this library.
https://symfony.com/doc/current/components/cache/psr6_psr16_adapters.html#using-a-psr-6-cache-object-as-a-psr-16-cache
References
From @evansims comment in #108 (comment):
Checklist
[x] I have read the Auth0 general contribution guidelines
[x] I have read the Auth0 Code of Conduct
[ ] All existing and new tests complete without errors