Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation Treebuilder::root #79

Merged
merged 2 commits into from
Oct 7, 2019
Merged

Fix deprecation Treebuilder::root #79

merged 2 commits into from
Oct 7, 2019

Conversation

darthf1
Copy link
Contributor

@darthf1 darthf1 commented Sep 27, 2019

Fix for the following:

The "Symfony\Component\Config\Definition\Builder\TreeBuilder::root()" method called for the "jwt_auth" configuration is deprecated since Symfony 4.3, pass the root name to the constructor instead.

It's fixed in a BC way. From: symfony/monolog-bundle@45742f1

Fix: The "Symfony\Component\Config\Definition\Builder\TreeBuilder::root()" method called for the "jwt_auth" configuration is deprecated since Symfony 4.3, pass the root name to the constructor instead.

From: symfony/monolog-bundle@45742f1
@darthf1 darthf1 requested a review from a team September 27, 2019 08:07
@joshcanhelp
Copy link
Contributor

Thanks @darthf1! When you say "BC" you mean backwards-compatible, correct? We use "BC" for breaking changes so I just wanted to make sure 😄

@darthf1
Copy link
Contributor Author

darthf1 commented Sep 28, 2019

Ah, yes it's backwards compatible. It checks if getRootNode exists (>= SF 4.2), If not, it sets the root node (< SF 4.2).

@joshcanhelp
Copy link
Contributor

joshcanhelp commented Oct 7, 2019

~/Sites/jwt-auth-bundle patch-1 19s
❯ php -v
PHP 7.2.18 (cli) (built: May 21 2019 20:18:44) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies
    with Xdebug v2.6.0, Copyright (c) 2002-2018, by Derick Rethans
    with Zend OPcache v7.2.18, Copyright (c) 1999-2018, by Zend Technologies

~/Sites/jwt-auth-bundle patch-1
❯ snyk test

Testing /Users/josh-cunningham/Sites/jwt-auth-bundle...

Organization:      auth0-sdks
Package manager:   composer
Target file:       composer.lock
Open source:       no
Project path:      /Users/josh-cunningham/Sites/jwt-auth-bundle
Licenses:          enabled

✓ Tested 33 dependencies for known issues, no vulnerable paths found.

@joshcanhelp joshcanhelp added this to the 3.2.1 milestone Oct 7, 2019
@joshcanhelp joshcanhelp merged commit 0626569 into auth0:master Oct 7, 2019
@darthf1 darthf1 deleted the patch-1 branch November 29, 2019 13:13
@darthf1 darthf1 mentioned this pull request Nov 29, 2019
@joshcanhelp joshcanhelp modified the milestones: 3.2.1, 3.3.0 Dec 5, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants