Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 5 support #87

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Symfony 5 support #87

merged 1 commit into from
Dec 5, 2019

Conversation

darthf1
Copy link
Contributor

@darthf1 darthf1 commented Dec 2, 2019

Changes

This PR adds support for Symfony 5. I only changed the version in composer.json.

Testing

Did some functional testing on my end, no additional entries in my log file and console. Seems to be working.

I did not add test coverage, since I have no experience on that topic. I was able to run the tests, and got the following:

HPUnit 5.7.27 by Sebastian Bergmann and contributors.

......EEE..E...EE........                                         25 / 25 (100%)

Time: 691 ms, Memory: 12.00MB

There were 6 errors:

1) Auth0\JWTAuthBundle\Tests\Security\Guard\JwtGuardAuthenticatorTest::testGetUserReturnsUnknownUserWhenJwtDecodingFails
Function ReflectionType::__toString() is deprecated

/srv/api/vendor/auth0/jwt-auth-bundle/Tests/Security/Guard/JwtGuardAuthenticatorTest.php:105

2) Auth0\JWTAuthBundle\Tests\Security\Guard\JwtGuardAuthenticatorTest::testGetUserReturnsUserThroughLoadUserByJWT
Function ReflectionType::__toString() is deprecated

/srv/api/vendor/auth0/jwt-auth-bundle/Tests/Security/Guard/JwtGuardAuthenticatorTest.php:140

3) Auth0\JWTAuthBundle\Tests\Security\Guard\JwtGuardAuthenticatorTest::testGetUserReturnsUserThroughLoadUserByUsername
Function ReflectionType::__toString() is deprecated

/srv/api/vendor/auth0/jwt-auth-bundle/Tests/Security/Guard/JwtGuardAuthenticatorTest.php:172

4) Auth0\JWTAuthBundle\Tests\Security\Guard\JwtGuardAuthenticatorTest::testOnAuthenticationSuccess
Function ReflectionType::__toString() is deprecated

/srv/api/vendor/auth0/jwt-auth-bundle/Tests/Security/Guard/JwtGuardAuthenticatorTest.php:230

5) Auth0\JWTAuthBundle\Tests\Security\JWTAuthenticatorTest::testTokenCreation
Function ReflectionType::__toString() is deprecated

/srv/api/vendor/auth0/jwt-auth-bundle/Tests/Security/JWTAuthenticatorTest.php:26

6) Auth0\JWTAuthBundle\Tests\Security\JWTAuthenticatorTest::testNoAuthorization
Function ReflectionType::__toString() is deprecated

/srv/api/vendor/auth0/jwt-auth-bundle/Tests/Security/JWTAuthenticatorTest.php:51

ERRORS!
Tests: 25, Assertions: 34, Errors: 6.

@darthf1 darthf1 requested a review from a team December 2, 2019 14:44
@joshcanhelp
Copy link
Contributor

Snyk passes locally:

❯ snyk test

Testing /Users/joshcanhelp/Sites/jwt-auth-bundle...

Organization:      auth0-sdks
Package manager:   composer
Target file:       composer.lock
Open source:       no
Project path:      /Users/josh-cunningham/Sites/jwt-auth-bundle
Licenses:          enabled

✓ Tested 35 dependencies for known issues, no vulnerable paths found.

@joshcanhelp joshcanhelp merged commit 91753fb into auth0:master Dec 5, 2019
@darthf1 darthf1 deleted the patch-1 branch December 5, 2019 22:08
@joshcanhelp joshcanhelp modified the milestones: 3.2.1, 3.3.0 Dec 5, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants