Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration authorized_issuer string or array compatibility #89

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Configuration authorized_issuer string or array compatibility #89

merged 2 commits into from
Dec 10, 2019

Conversation

antzo
Copy link
Contributor

@antzo antzo commented Dec 9, 2019

Changes

Fix BC introduced in last PR. Now the authorized_issuer can really be a string or an array. I also added tests to the Configuration

Testing

[x] This change adds test coverage
[x] All existing and new tests complete without errors

@antzo antzo requested a review from a team December 9, 2019 09:30
@antzo antzo mentioned this pull request Dec 9, 2019
Merged
@joshcanhelp joshcanhelp requested review from joshcanhelp and removed request for a team December 9, 2019 18:21
@joshcanhelp
Copy link
Contributor

@antzo - Did you pull the latest before creating this PR? Looks like you've got a conflict to resolve.

@joshcanhelp joshcanhelp added this to the 3.3.1 milestone Dec 9, 2019
@antzo
Copy link
Contributor Author

antzo commented Dec 10, 2019

@joshcanhelp 3.3 merged. thanks :)

@joshcanhelp
Copy link
Contributor 

~/Sites/jwt-auth-bundle antzo-master
❯ snyk test

Testing /Users/josh-cunningham/Sites/jwt-auth-bundle...

Organization:      auth0-sdks
Package manager:   composer
Target file:       composer.lock
Open source:       no
Project path:      /Users/josh-cunningham/Sites/jwt-auth-bundle
Licenses:          enabled

✓ Tested 35 dependencies for known issues, no vulnerable paths found.

joshcanhelp
joshcanhelp approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antzo - Looks good, thank you for the fast turn-around here!

@joshcanhelp joshcanhelp merged commit 862587e into auth0:master Dec 10, 2019
@joshcanhelp
Copy link
Contributor

Forced merge as checks are not completing for forked PRs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshcanhelp joshcanhelp joshcanhelp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@antzo @joshcanhelp