Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DXCDT-98 Stop ignoring errors when setting resource data within the resource server #105

Merged
merged 2 commits into from
Mar 30, 2022
Merged

DXCDT-98 Stop ignoring errors when setting resource data within the resource server #105

merged 2 commits into from
Mar 30, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Mar 29, 2022 •
edited
Loading

Description

This PR stops ignoring errors when setting resource data within the resource server.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • Yes
  • Not needed

Does the description provide the correct amount of context?

  • Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Is this code ready for production?

  • Yes, all code changes are intentional and no debugging calls are left over

@sergiught sergiught self-assigned this Mar 29, 2022
@sergiught sergiught marked this pull request as ready for review March 29, 2022 13:04
@sergiught sergiught requested a review from a team as a code owner March 29, 2022 13:04
@sergiught sergiught merged commit 8dcae01 into main Mar 30, 2022
@sergiught sergiught deleted the patch/DXCDT-98-resource-server branch March 30, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willvedd willvedd willvedd approved these changes

Assignees

@sergiught sergiught

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergiught @willvedd