Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversion issue flattenAddons func in client resource #140

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Apr 14, 2022

Description

Fixes #139

Fixes issue with the logout property on flattenAddons where we're trying to typecast it always to a map[string]interface{} without checking if it was actually present in the payload.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • Yes
  • Not needed

Does the description provide the correct amount of context?

  • Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Is this code ready for production?

  • Yes, all code changes are intentional and no debugging calls are left over

@sergiught sergiught self-assigned this Apr 14, 2022
@sergiught sergiught requested a review from a team as a code owner April 14, 2022 14:07
}
`

const testAccClientConfigWithoutAddonsWithSAMLPLogout = `
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, I think it would've made sense to keep this as the default testAccClientConfig and then label the above testAccClientConfigWithoutAddonsWithoutSAMLPLogout but just a small amount of 🚲 🏠 'ing.

@sergiught sergiught merged commit cb5ed0f into main Apr 14, 2022
@sergiught sergiught deleted the patch/issue-139 branch April 14, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider Crashing on Specific Tenant
2 participants