-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DXCDT-159] Fix #159 and refactor guardian resource implementation #195
Conversation
f0d7934
to
db89878
Compare
db89878
to
e866a35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just left a comment about the test case name (and a couple of test constants).
Codecov Report
@@ Coverage Diff @@
## main #195 +/- ##
==========================================
+ Coverage 83.89% 83.92% +0.03%
==========================================
Files 35 35
Lines 6059 6058 -1
==========================================
+ Hits 5083 5084 +1
+ Misses 773 771 -2
Partials 203 203
Continue to review full report at Codecov.
|
Description
Fixes: #159
The constant diffs and the apply errors we were getting were because the
"phone-message-hook"
provider for thephone
block has no options configurable, but theauth0
andtwilio
ones do. To account for this and to correctly read theprovider
andphone.options
block, thephone.options
is set to aComputed
property and we explicitly set them in case of"phone-message-hook"
to[]interface{nil}
.While fixing this we also went ahead and refactored the implementation ensuring that:
We now also skip unnecessary API calls if the phone factor is disabled when reading.
Checklist
Note: Checklist required to be completed before a PR is considered to be reviewable.
Auth0 Code of Conduct
Auth0 General Contribution Guidelines
Changes include test coverage?
Does the description provide the correct amount of context?
Have you updated the documentation?
Is this code ready for production?