Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication params non-map flatten warning (3/3) #241

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Jul 14, 2022

Description

Including a warning for the unlikely event that an existing connection's authentication params are unable to be cast into a string map. This can occur because there is no validation on that configuration property and technically any valid JSON is accepted. The authentication params field, from our best understanding should strictly be a map of strings. But alas, if it is not, we should display an actionable warning to the user.

This work is enabled by #240, otherwise this logging code would be unnecessarily distributed away from the source of the code.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • Yes
  • Not needed

Does the description provide the correct amount of context?

  • Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Is this code ready for production?

  • Yes, all code changes are intentional and no debugging calls are left over

@codecov-commenter
Copy link

Codecov Report

Merging #241 (329f1da) into flatten-connection-options-return-diag-type (e1befef) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@                               Coverage Diff                               @@
##           flatten-connection-options-return-diag-type     #241      +/-   ##
===============================================================================
+ Coverage                                        82.64%   82.70%   +0.05%     
===============================================================================
  Files                                               36       36              
  Lines                                             6853     6857       +4     
===============================================================================
+ Hits                                              5664     5671       +7     
+ Misses                                             938      936       -2     
+ Partials                                           251      250       -1     
Impacted Files Coverage Δ
auth0/structure_auth0_connection.go 84.48% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1befef...329f1da. Read the comment docs.

sergiught
sergiught previously approved these changes Jul 15, 2022
@sergiught sergiught force-pushed the flatten-connection-options-return-diag-type branch 3 times, most recently from da61912 to e53edb4 Compare July 15, 2022 14:44
Base automatically changed from flatten-connection-options-return-diag-type to main July 15, 2022 14:47
@sergiught sergiught merged commit a073bf1 into main Jul 15, 2022
@sergiught sergiught deleted the auth-params-flatten-warning branch July 15, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants