Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with importing auth0_organization_member #302

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Aug 26, 2022

🔧 Changes

Similar to #301, the same issue is present within the org_member resource as well.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught self-assigned this Aug 26, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (patch/issue#299-org-conn-fix@bc9ceff). Click here to learn what that means.
The diff coverage is 100.00%.

@@                       Coverage Diff                       @@
##             patch/issue#299-org-conn-fix     #302   +/-   ##
===============================================================
  Coverage                                ?   85.30%           
===============================================================
  Files                                   ?       39           
  Lines                                   ?     8267           
  Branches                                ?        0           
===============================================================
  Hits                                    ?     7052           
  Misses                                  ?      964           
  Partials                                ?      251           
Impacted Files Coverage Δ
...nal/provider/resource_auth0_organization_member.go 78.52% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sergiught sergiught force-pushed the patch/issue#299-org-member-fix branch from e25f3a7 to 2ab1b48 Compare August 26, 2022 07:57
@sergiught sergiught marked this pull request as ready for review August 26, 2022 07:57
@sergiught sergiught requested a review from a team as a code owner August 26, 2022 07:57
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. I think establishing this convention in the codebase will improve the import process overall.

Base automatically changed from patch/issue#299-org-conn-fix to main August 26, 2022 17:02
@sergiught sergiught merged commit 0c4f30d into main Aug 26, 2022
@sergiught sergiught deleted the patch/issue#299-org-member-fix branch August 26, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants