Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue#547: Fix auth0 management api data source not reading scopes #555

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Becase we were reusing the read func from the resource server, we were errouneously skipping reading the scopes for the Auth0 Management API. This PR fixes that.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 80.64% and project coverage change: -0.03 ⚠️

Comparison is base (a5b6763) 86.22% compared to head (92c1e8a) 86.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   86.22%   86.20%   -0.03%     
==========================================
  Files          67       67              
  Lines        9912     9938      +26     
==========================================
+ Hits         8547     8567      +20     
- Misses       1068     1073       +5     
- Partials      297      298       +1     
Impacted Files Coverage Δ
internal/auth0/resourceserver/data_source.go 89.09% <80.64%> (-10.91%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sergiught sergiught marked this pull request as ready for review April 19, 2023 11:29
@sergiught sergiught requested a review from a team as a code owner April 19, 2023 11:29
@sergiught sergiught merged commit e0334ec into main Apr 20, 2023
@sergiught sergiught deleted the issue#547/data-api branch April 20, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants