Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-424: Renaming auth0_trigger_binding to auth0_trigger_actions #613

Merged
merged 8 commits into from
Jun 6, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented May 31, 2023

🔧 Changes

Introducing a auth0_trigger_actions resource which will be the replacement of the auth0_trigger_binding resource. Both have virtually the same functionality with exception of the deprecation notice. The two resources will coexist until the upcoming v1 major release, at which point the auth0_trigger_binding resource can be deleted.

🔬 Testing

Tests and recordings have been migrated from the old name to the new name.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner May 31, 2023 20:39
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Merging #613 (bc143b6) into main (92759d1) will increase coverage by 0.05%.
The diff coverage is 87.36%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
+ Coverage   86.59%   86.65%   +0.05%     
==========================================
  Files          76       77       +1     
  Lines       11896    11896              
==========================================
+ Hits        10301    10308       +7     
+ Misses       1220     1213       -7     
  Partials      375      375              
Impacted Files Coverage Δ
internal/provider/provider.go 100.00% <ø> (ø)
internal/auth0/action/resource_trigger_actions.go 86.81% <86.81%> (ø)
internal/auth0/action/resource_trigger_binding.go 100.00% <100.00%> (+19.38%) ⬆️

@willvedd willvedd requested a review from sergiught June 2, 2023 18:15
@willvedd willvedd enabled auto-merge (squash) June 2, 2023 18:36
willvedd and others added 2 commits June 6, 2023 10:38
Co-authored-by: Sergiu Ghitea <28300158+sergiught@users.noreply.github.com>
Co-authored-by: Sergiu Ghitea <28300158+sergiught@users.noreply.github.com>
@willvedd willvedd merged commit 6504fec into main Jun 6, 2023
@willvedd willvedd deleted the DXCDT-424-auth0-trigger-actions branch June 6, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants