[1/2] DXCDT-457: Add auth0_organization_members resource
#614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
changed the title
auth0_organization_members resourceauth0_organization_members resource
2 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
==========================================
- Coverage 86.65% 86.51% -0.14%
==========================================
Files 77 78 +1
Lines 11896 12047 +151
==========================================
+ Hits 10308 10423 +115
- Misses 1213 1244 +31
- Partials 375 380 +5
|
Widcket
reviewed
Jun 5, 2023
Widcket
approved these changes
Jun 5, 2023
willvedd
suggested changes
Jun 6, 2023
| return diag.FromErr(err) | ||
| } | ||
|
|
||
| data.SetId(organizationID) |
There was a problem hiding this comment.
Suggestion - perhaps set the ID after successfully assigning members to the org. That way you can remove the data.SetId("") on line 76.
There was a problem hiding this comment.
While that might be nicer and tidier code wise, if the organization exists we should immediately set the ID of this resource IMO. Any error resulting from the AddMembers call shouldn't erase the resource from the state (that's what happens if we don't set the ID).
sergiught
force-pushed
the
feature/DXCDT-457-org-members
branch
from
9d1583d
to
e3933b9
Compare
sergiught
force-pushed
the
feature/DXCDT-457-org-members
branch
from
e3933b9
to
14c962c
Compare
Widcket
approved these changes
Jun 7, 2023
willvedd
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Add
auth0_organization_membersresource to manage the members of an organization in a 1:many resource. Members are added to the org data source in #615.📚 References
auth0_organizationdata source #615🔬 Testing
📝 Checklist