GH-587: Fix set_user_root_attributes attribute on enterprise connections
#619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #619 +/- ##
==========================================
+ Coverage 86.59% 86.62% +0.03%
==========================================
Files 76 76
Lines 11896 11926 +30
==========================================
+ Hits 10301 10331 +30
Misses 1220 1220
Partials 375 375
|
Widcket
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
The
set_user_root_attributesattribute on the enterprise connections seem to not be behaving consistently for more than justwaadconnections, as reported in the original issue. After testing all of them we patch the ones that don't consistently show the sync at each login toggle as enabled.📚 References
🔬 Testing
📝 Checklist