Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2/X] DXCDT-455: Fix import issue in auth0_user_role resource #629

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Jun 13, 2023

🔧 Changes

Fixes an import issue in auth0_user_role resource.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught force-pushed the patch/DXCDT-455-import-tests-user-roles branch from 88bcc92 to a99b631 Compare June 13, 2023 09:02
@sergiught sergiught force-pushed the patch/DXCDT-455-import-tests-user-role branch 4 times, most recently from 211b445 to 449016b Compare June 13, 2023 09:34
@sergiught sergiught force-pushed the patch/DXCDT-455-import-tests-user-roles branch from a99b631 to a5197b1 Compare June 13, 2023 09:46
@sergiught sergiught force-pushed the patch/DXCDT-455-import-tests-user-role branch from 449016b to 51ca2c0 Compare June 13, 2023 09:48
@codecov-commenter
Copy link

Codecov Report

Merging #629 (51ca2c0) into patch/DXCDT-455-import-tests-user-roles (a5197b1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                             Coverage Diff                             @@
##           patch/DXCDT-455-import-tests-user-roles     #629      +/-   ##
===========================================================================
+ Coverage                                    86.83%   86.85%   +0.01%     
===========================================================================
  Files                                           80       80              
  Lines                                        12292    12290       -2     
===========================================================================
  Hits                                         10674    10674              
+ Misses                                        1231     1229       -2     
  Partials                                       387      387              
Impacted Files Coverage Δ
internal/auth0/user/resource_role.go 73.52% <100.00%> (+2.10%) ⬆️

@sergiught sergiught marked this pull request as ready for review June 13, 2023 09:56
@sergiught sergiught requested a review from a team as a code owner June 13, 2023 09:56
Base automatically changed from patch/DXCDT-455-import-tests-user-roles to main June 13, 2023 15:26
@sergiught sergiught force-pushed the patch/DXCDT-455-import-tests-user-role branch from 51ca2c0 to b84a0d9 Compare June 13, 2023 15:34
@sergiught sergiught merged commit 83af416 into main Jun 13, 2023
@sergiught sergiught deleted the patch/DXCDT-455-import-tests-user-role branch June 13, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants