Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DXCDT-77] Fix attack protection resource for psaas tenants #86

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Mar 10, 2022

Description

This PR accounts for PSAAS environments that don't have the Stage property set on the SuspiciousIPThrottling setting.

We also improving error handling and making it much more robust within the attack_protection resource.

Fixes: #85.

Checklist

Note: Checklist required to be completed before a PR is considered to be reviewable.

Auth0 Code of Conduct

Auth0 General Contribution Guidelines

Changes include test coverage?

  • Yes
  • Not needed

Does the description provide the correct amount of context?

  • Yes, the description provides enough context for the reviewer to understand what these changes accomplish

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

Is this code ready for production?

  • Yes, all code changes are intentional and no debugging calls are left over

@sergiught sergiught force-pushed the patch/DXCDT-77-fix-attack-protection branch from 2cf3d2e to 79d86ee Compare March 10, 2022 11:27
@sergiught sergiught marked this pull request as ready for review March 10, 2022 14:46
@sergiught sergiught requested a review from a team as a code owner March 10, 2022 14:46
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate that you've jumped on a fix for this, but can we take a moment to learn the facts? There is a lot of fear and uncertainty around the API which sours the code. Instead of hastily applying a code patch, can we instead identify what the PSaaS API actually returns?

In addition to learning the full scope of this issue, can we also understand if this is something that we actually want to address with code? Perhaps we can identify workarounds or work with the relevant product teams to understand what a more holistic fix looks like. Given that Layer0 is on the horizon, we may be able to wait.

auth0/resource_auth0_attack_protection.go Show resolved Hide resolved
auth0/resource_auth0_attack_protection.go Show resolved Hide resolved
auth0/resource_auth0_attack_protection.go Outdated Show resolved Hide resolved
@sergiught sergiught force-pushed the patch/DXCDT-77-fix-attack-protection branch from 79d86ee to b6f9495 Compare March 11, 2022 08:57
@sergiught sergiught requested review from a team and willvedd March 11, 2022 09:33
@sergiught sergiught force-pushed the patch/DXCDT-77-fix-attack-protection branch from b6f9495 to ad25b88 Compare March 11, 2022 17:32
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for walking me through this!

@sergiught sergiught merged commit e8324c5 into main Mar 11, 2022
@sergiught sergiught deleted the patch/DXCDT-77-fix-attack-protection branch March 11, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attack Protection does not work
2 participants