[WIP] Admin settings screen refactor #396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror messages when plugin is not setup
…ror when not connected; default option reordering; simplifying render_a0_switch; adding render_text_field, render_radio_button, render_field_description, get_dashboard_link; refactoring WP_Auth0_Admin_Basic render functions
… adding and working in get_docs_link; tweaks to render_text_field; adding render_textarea_field
… management; renamed render_a0_switch -> render_switch; added render_social_key_field
…in tab; removing API audience field; settings field description editing, link checking; fixing Gravatar integration; reverting Dashboard removal to put in a different PR
joshcanhelp
force-pushed
the
fixed-admin-settings-screen
branch
from
b4c4c03
to
65966fb
Compare
joshcanhelp
changed the title
joshcanhelp
commented
Mar 23, 2018
| @@ -51,12 +51,8 @@ public static function get_connect_info( $opt = '' ) { | |||
| 'client_secret_encoded' => $a0_options->get( 'client_secret_b64_encoded' ), | |||
| 'connection' => $a0_options->get( 'db_connection_name' ), | |||
| 'app_token' => $a0_options->get( 'auth0_app_token' ), | |||
| 'audience' => $a0_options->get( 'api_audience' ), | |||
| 'audience' => self::get_endpoint( 'api/v2/' ), | |||
There was a problem hiding this comment.
This is for the Management API and the audience for that can't be changed so no reason to have it be editable
joshcanhelp
commented
Mar 23, 2018
| * Default settings when plugin is installed or reset | ||
| * | ||
| * @return array | ||
| */ | ||
| protected function defaults() { | ||
| return array( |
There was a problem hiding this comment.
Grouping by settings page tab, reordering by actual field order displayed
joshcanhelp
commented
Mar 23, 2018
| wp_enqueue_style( 'wpa0_bootstrap', WPA0_PLUGIN_URL . 'assets/bootstrap/css/bootstrap.min.css' ); | ||
| wp_enqueue_script( 'wpa0_bootstrap', WPA0_PLUGIN_URL . 'assets/bootstrap/js/bootstrap.min.js' ); | ||
| wp_enqueue_style( 'wpa0_admin_initial_settup', WPA0_PLUGIN_URL . 'assets/css/initial-setup.css' ); | ||
| wp_enqueue_script( |
There was a problem hiding this comment.
Adding version numbers to act as cache breakers when needed. Otherwise the WP version is used.
joshcanhelp
commented
Mar 23, 2018
| } | ||
| } | ||
|
|
||
| public function cant_connect_to_auth0() { |
There was a problem hiding this comment.
There were multiple "no ready to handle login" messages, combined these into 1
joshcanhelp
commented
Mar 23, 2018
| ) ); | ||
| } | ||
|
|
||
| protected function validate_required_api_scopes() { |
There was a problem hiding this comment.
An API token is not required, should not throw an admin error if missing
joshcanhelp
commented
Mar 23, 2018
| @@ -159,20 +146,6 @@ public function input_validator( $input ) { | |||
| return $input; | |||
| } | |||
|
|
|||
| public function create_account_message() { | |||
There was a problem hiding this comment.
There were multiple "no ready to handle login" messages, combined these into 1
joshcanhelp
commented
Mar 23, 2018
| array( 'id' => 'wpa0_auth0_server_domain', 'name' => 'Auth0 server domain', 'function' => 'render_auth0_server_domain' ), | ||
| array( 'id' => 'wpa0_metrics', 'name' => 'Anonymous data', 'function' => 'render_metrics' ), | ||
|
|
||
| array( 'id' => 'wpa0_verified_email', |
There was a problem hiding this comment.
Reordered, changed titles, and adjusted for line length. The reordering and title changes made for a big replace block in the diff here so just went ahead and reformatted also.
joshcanhelp
force-pushed
the
fixed-admin-settings-screen
branch
2 times, most recently
from
7c7f119
to
a14ea9d
Compare
…ess method to old code, will be addressed in another branch
joshcanhelp
force-pushed
the
fixed-admin-settings-screen
branch
from
a14ea9d
to
da2084b
Compare
joshcanhelp
changed the title
joshcanhelp
added a commit
that referenced
this pull request
Mar 26, 2018
Admins settings have confusing wording, inconsistent behavior, and broken links and translation. This first PR refactors the description system to be more straight-forward, adds HTML generation functions for consistent field outputs (used in future commits), and fixes a few other minor issues. First of a few smaller PRs to replace #396
joshcanhelp
added a commit
that referenced
this pull request
Mar 26, 2018
Admins settings have confusing wording, inconsistent behavior, and broken links and translation. This first PR refactors the description system to be more straight-forward, adds HTML generation functions for consistent field outputs (used in future commits), adds settings page description translation, and fixes a few other minor code issues. First of a few smaller PRs to replace #396
joshcanhelp
added a commit
that referenced
this pull request
Mar 26, 2018
Admins settings have confusing wording, inconsistent behavior, and broken links and translation. This first PR refactors the description system to be more straight-forward, adds HTML generation functions for consistent field outputs (used in future commits), adds settings page description translation, and fixes a few other minor code issues. First of a few smaller PRs to replace #396
joshcanhelp
added a commit
that referenced
this pull request
Mar 27, 2018
Admins settings have confusing wording, inconsistent behavior, and broken links and translation. This first PR refactors the description system to be more straight-forward, adds HTML generation functions for consistent field outputs (used in future commits), adds settings page description translation, and fixes a few other minor code issues. First of a few smaller PRs to replace #396
joshcanhelp
added a commit
that referenced
this pull request
Apr 13, 2018
Admins settings have confusing wording, inconsistent behavior, and broken links and translation. This first PR refactors the description system to be more straight-forward, adds HTML generation functions for consistent field outputs (used in future commits), adds settings page description translation, and fixes a few other minor code issues. First of a few smaller PRs to replace #396
|
Parsed into several smaller PRs |
joshcanhelp
added a commit
that referenced
this pull request
Jun 5, 2018
Admins settings have confusing wording, inconsistent behavior, and broken links and translation. This first PR refactors the description system to be more straight-forward, adds HTML generation functions for consistent field outputs (used in future commits), adds settings page description translation, and fixes a few other minor code issues. First of a few smaller PRs to replace #396
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Breaking this up into smaller components for review
Large refactor for wp-admin settings screen to improve the code, add missing translations, rewrite settings descriptions, and other minor improvements. Complete list:
WP_Auth0_Admin_Generic