Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix help tab text and settings tab UX #452

Merged
merged 1 commit into from
May 1, 2018
Merged

Fix help tab text and settings tab UX #452

merged 1 commit into from
May 1, 2018

Conversation

joshcanhelp
Copy link
Contributor

  • Fixed the help tab text to correct links and match merged changes to readme
  • Fixed the tabs jumping to the anchor link used
  • Combined settings tab JS to external file; refactored for simplicity
  • Removed unused logo styling

@joshcanhelp joshcanhelp added this to the v3-Next milestone Apr 30, 2018
@cocojoe cocojoe self-requested a review May 1, 2018 15:32
cocojoe
cocojoe approved these changes May 1, 2018
View reviewed changes
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshcanhelp joshcanhelp merged commit f6853de into dev May 1, 2018
@joshcanhelp joshcanhelp deleted the change-settings-help-tab branch May 1, 2018 15:43
@joshcanhelp joshcanhelp mentioned this pull request Jun 5, 2018
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cocojoe cocojoe cocojoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @cocojoe