Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load ourselves with Composer autoloader #787

Merged
merged 5 commits into from
Apr 6, 2020
Merged

Load ourselves with Composer autoloader #787

merged 5 commits into from
Apr 6, 2020

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Apr 6, 2020 •
edited
Loading

Closes #783

@szepeviktor szepeviktor requested a review from a team April 6, 2020 14:44
joshcanhelp
joshcanhelp suggested changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szepeviktor - We only just started using a Composer package in the distributed version of the plugin (was dev requirements only previously) and I didn't look into the autoloading in-depth before releasing. Looks like a solid improvement so thank you!

I have a few comments below but the main one is ... I ran composer update on this branch but I'm getting not found errors for all the functions. Are you able to run this as-is locally?

WP_Auth0.php Show resolved Hide resolved
WP_Auth0.php Show resolved Hide resolved
@szepeviktor szepeviktor mentioned this pull request Apr 6, 2020
Merged
joshcanhelp
joshcanhelp suggested changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things and we'll be ready to get this in. Appreciate your work here 🙏

WP_Auth0.php Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
szepeviktor and others added 2 commits April 6, 2020 19:51
@szepeviktor @joshcanhelp
Update deprecation version
c7558ef 
Co-Authored-By: Josh Cunningham <josh@joshcanhelp.com>
@szepeviktor @joshcanhelp
Fix license in composer.json
25931c2 
Co-Authored-By: Josh Cunningham <josh@joshcanhelp.com>
@szepeviktor
Copy link
Contributor Author

Couple small things and we'll be ready to get this in.

I ❤️ to work for professionals. Please hire me for free!

@joshcanhelp
Copy link
Contributor 

> "vendor/bin/phpcs"
............................................................ 60 / 66 (91%)
......                                                       66 / 66 (100%)


Time: 18.48 secs; Memory: 22MB

> "vendor/bin/phpunit"
Installing...
Running as single site... To run multisite, use -c tests/phpunit/multisite.xml
Not running ajax tests. To execute these, use --group ajax.
Not running ms-files tests. To execute these, use --group ms-files.
Not running external-http tests. To execute these, use --group external-http.
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.1.33 with Xdebug 2.6.1
Configuration: /Users/josh-cunningham/Sites/wp-auth0/wp-content/plugins/auth0/phpunit.xml.dist

...............................................................  63 / 409 ( 15%)
............................................................... 126 / 409 ( 30%)
............................................................... 189 / 409 ( 46%)
............................................................... 252 / 409 ( 61%)
............................................................... 315 / 409 ( 77%)
............................................................... 378 / 409 ( 92%)
...............................                                 409 / 409 (100%)

Time: 20.6 seconds, Memory: 48.00MB

OK (409 tests, 1561 assertions)

@szepeviktor
Copy link
Contributor Author

I work for SaaS startups but none of them are professionals.

You seem to be someone taking control of things.

@joshcanhelp joshcanhelp merged commit a9239d1 into auth0:master Apr 6, 2020
@szepeviktor szepeviktor deleted the autoloader-v2 branch April 6, 2020 18:01
@joshcanhelp
Copy link
Contributor

@szepeviktor - Appreciate the kind words same to you as well! 🙇

@joshcanhelp joshcanhelp added this to the 4.1.0 milestone Apr 6, 2020
@szepeviktor
Copy link
Contributor Author

You're welcome.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshcanhelp joshcanhelp joshcanhelp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

Current custom autoloader is very slow
2 participants
@szepeviktor @joshcanhelp