Fix wrong response_type parsed when missing response_mode #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lakhansamani Please kindly review this PR and release a new version soon, thanks. |
|
Thanks @JokerQyou for the contribution |
|
@JokerQyou released as part of 1.1.52 (https://github.com/authorizerdev/authorizer/releases/tag/1.1.52) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The original code incorrectly read configured default
respone_modevalue into a variable holdingresponse_typevalue. This causes OAuth2 requests withoutresponse_modepassed via URL query parameter to fail, becauseresponse_typevalue will then be filled with illegal value.Which issue(s) does this PR fix?
There's no issue at this point. I was testing integration with Memos and found this coding typo. Their SSO implementation does not pass
response_mode, thus resulting in error.If this PR affects any API reference documentation, please share the updated endpoint references
There's no API change.