Feat: add screen_hint param in /authorize api for explicit signup redirection #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakhansamani
requested changes
Nov 21, 2023
server/handlers/authorize.go
Outdated
| if err := memorystore.Provider.SetState(state, nonce); err != nil { | ||
| log.Debug("Error setting temp code", err) | ||
| } | ||
| } | ||
|
|
||
| loginURL := "/app?" + loginState | ||
| authURL := "/app?" + authState |
There was a problem hiding this comment.
Good idea is to not put ? & # in authURL use it or declare another variable which just holds path /appor /app/signup and use that variable in line 140, 144, 146
There was a problem hiding this comment.
Updated the changes and added social media buttons on signup page
lakhansamani
approved these changes
Nov 21, 2023
server/constants/oauth2.go
Outdated
| @@ -16,4 +16,7 @@ const ( | |||
| ResponseTypeToken = "token" | |||
| // For the Implicit grant of id_token, use response_type=id_token to include an identifier token. | |||
| ResponseTypeIDToken = "id_token" | |||
|
|
|||
| // Constant indicating the "signup" screen hint for customizing authentication process and redirect to a signup page. | |||
| ScreenHint = "signup" | |||
There was a problem hiding this comment.
Lets rename this const to ScreenHintSignUp
If there is something else available for screen hint then also we can accomodate
There was a problem hiding this comment.
Yes True,
Updated!
lakhansamani
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable signup redirection via screen_hint param in /authorize API
Which issue(s) does this PR fix?
If this PR affects any API reference documentation, please share the updated endpoint references
authorizerdev/docs#50