Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect front-end to the back-end #24

Merged
merged 16 commits into from
Mar 25, 2022
Merged

Conversation

cedpoilly
Copy link
Contributor

@cedpoilly cedpoilly commented Feb 22, 2022

Work in progress. You can see a demo of the user registration. @hkd987 Seems like we can register multiple times with the same email address. Am I missing something?

@cedpoilly cedpoilly changed the title Fe connect WIP: Connect front-end to the back-end Feb 22, 2022
@hkd987
Copy link
Contributor

hkd987 commented Feb 22, 2022

I think I know where the bug is, I’ll get a fix up for that issue.

@hkd987
Copy link
Contributor

hkd987 commented Feb 23, 2022

I noticed that you are adding register logic, but this seems like it should be included in the iframe and then the frontend should bring in the iframe.

@cedpoilly
Copy link
Contributor Author

I noticed that you are adding register logic, but this seems like it should be included in the iframe and then the frontend should bring in the iframe.

Should we have the iframe logic in the Front-End folder directly?

@hkd987
Copy link
Contributor

hkd987 commented Feb 25, 2022

I think the frame should have its own logic, and be self contained.

Remember that the iframe will be a drop in not only for our website but for others login UIs

@cedpoilly
Copy link
Contributor Author

Right. I misread you earlier. I'll move that logic to the iframe folder. Then I'll add the code for the Front-End folder

@cedpoilly
Copy link
Contributor Author

@hkd987 @evanyang1 You can test the register and login features by starting a static server in the /iframe folder

backend/.env.example Outdated Show resolved Hide resolved
@cedpoilly
Copy link
Contributor Author

@hkd987 Here is the current workflow:

  1. Start the back-end, start the front-end and start a static server for the iframe
  2. Login via the iframe
    -> you will be redirected to localhost:3000 and the x-api-key and jwt will be set in the localStorage. Then the dashboard will be loaded.
  3. Create, update and delete the projects.

@hkd987 hkd987 merged commit db77f16 into authsio:main Mar 25, 2022
@cedpoilly cedpoilly changed the title WIP: Connect front-end to the back-end Connect front-end to the back-end Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants