Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require node >=18 #1231

Merged
merged 1 commit into from
Nov 2, 2023
Merged

require node >=18 #1231

merged 1 commit into from
Nov 2, 2023

Conversation

pamapa
Copy link
Member

@pamapa pamapa commented Nov 2, 2023

Checklist

  • This PR makes changes to the public API
  • I have included links for closing relevant issue numbers

@pamapa pamapa added this to the 3.0.0 milestone Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c2f93d4) 78.16% compared to head (cf9acde) 78.16%.

❗ Current head cf9acde differs from pull request most recent head 3eecb24. Consider uploading reports for the commit 3eecb24 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1231   +/-   ##
=======================================
  Coverage   78.16%   78.16%           
=======================================
  Files          45       45           
  Lines        1731     1731           
  Branches      345      345           
=======================================
  Hits         1353     1353           
  Misses        341      341           
  Partials       37       37           
Flag Coverage Δ
unittests 78.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pamapa pamapa merged commit 2a308c6 into main Nov 2, 2023
2 checks passed
@pamapa pamapa deleted the update-node branch November 2, 2023 09:17
@garronej
Copy link

garronej commented Feb 7, 2024

Hello Thanks for your work,

Not arguing or anything but would explain the motivation behind this requirement?

It my case it required me to update the Dockerfile that build my SPA.

Best regards,

@pamapa
Copy link
Member Author

pamapa commented Feb 7, 2024

Done with a 3.0.0 a major release and node 18 is maintained where 16 is no longer. I plan to keep that dependency now longer though, probably unless a new major release or demanding feature...

@garronej
Copy link

garronej commented Feb 7, 2024

Ok, thanks for your answer! However, corect me if I'm mistaking oidc-client-ts is a purely client side library that does not comes with any scripts. So ther's nothing really runing in node there is it?

@garronej
Copy link

garronej commented Feb 7, 2024

SSR I guess, my bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants